Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933106Ab2EYVWJ (ORCPT ); Fri, 25 May 2012 17:22:09 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:26057 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753467Ab2EYVWG (ORCPT ); Fri, 25 May 2012 17:22:06 -0400 Date: Fri, 25 May 2012 17:15:24 -0400 From: Konrad Rzeszutek Wilk To: "Liu, Jinsong" Cc: Borislav Petkov , "linux-kernel@vger.kernel.org" , "Luck, Tony" , "xen-devel@lists.xensource.com" Subject: Re: [Xen-devel] [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (v2) Message-ID: <20120525211524.GC21344@phenom.dumpdata.com> References: <20120524103023.GA27063@aftab.osrc.amd.com> <20120524162605.GK27063@aftab.osrc.amd.com> <20120524191039.GB28338@phenom.dumpdata.com> <20120525180303.GB27280@phenom.dumpdata.com> <20120525202309.GA14524@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1369 Lines: 37 On Fri, May 25, 2012 at 08:47:20PM +0000, Liu, Jinsong wrote: > Konrad Rzeszutek Wilk wrote: > >> What I mean is, > >> If mcelog.c create /dev/xen-mcelog (say, minor=226), native mce.c > >> would create /dev/mcelog (minor=227). > >> Under such case, may we create a symlink in /dev/mcelog pointing to > >> /dev/xen-mcelog, without touching native mce code? and how? > > > > I thought the idea was that we would create /dev/mcelog using the > > same major/minor. > > Our current patch just use same major/minor, by redirection method. Is it acceptable? https://lkml.org/lkml/2012/5/24/183 Borislav says: " Maybe create a symlink in /dev/mcelog pointing to /dev/xen-mcelog? That should solve it. " so that sounds like the right direction. > > > > > However if you want to create /dev/xen-mcelog and then create from > > the kernel another file in /dev that is name 'mcelog' and is a > > symlink to /dev/mcelog - that is OK too. Obviously you will also need > > to disable the generic '/dev/mcelog' (and that can be done in the > > same way as lguest does it). > > No, that's not my purpose. > > Thanks, > Jinsong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/