Date: Fri, 25 May 2012 18:30:45 -0300
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 3/4] perf top: Fix counter name fixup when fallbacking to
 cpu-clock
Message-ID: <20120525213045.GH2336@infradead.org>
References: <1337975958-24047-1-git-send-email-acme@infradead.org>
 <1337975958-24047-4-git-send-email-acme@infradead.org>
 <4FBFEAFA.8050004@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FBFEAFA.8050004@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 709
Lines: 21

Em Fri, May 25, 2012 at 02:26:34PM -0600, David Ahern escreveu:
> The patch I sent had:
> 
> + if (counter->name) {
> + free(counter->name);
> + counter->name = NULL;
> + counter->name = strdup(event_name(counter));
> + }
> 
> See http://lkml.indiana.edu/hypermail/linux/kernel/1205.1/00390.html

I probably messed up this one, should've put a committer note for that
stupid simplification, anyway, just setting it to NULL is enough and
less confusing.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/