Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754857Ab2EZT6L (ORCPT ); Sat, 26 May 2012 15:58:11 -0400 Received: from ngcobalt02.manitu.net ([217.11.48.102]:58640 "EHLO ngcobalt02.manitu.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754383Ab2EZT6J (ORCPT ); Sat, 26 May 2012 15:58:09 -0400 X-manitu-Original-Sender-IP: 79.230.31.106 X-manitu-Original-Receiver-Name: ngcobalt02.manitu.net Message-ID: <4FC135C6.5030206@grandegger.com> Date: Sat, 26 May 2012 21:57:58 +0200 From: Wolfgang Grandegger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Federico Vaga CC: Marc Kleine-Budde , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Giancarlo Asnaghi , Alan Cox Subject: Re: [PATCH] STA2X11 CAN: CAN driver for the STA2X11 board References: <1337288364-17572-1-git-send-email-federico.vaga@gmail.com> <4FB5E581.1090209@grandegger.com> In-Reply-To: X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 31 On 05/26/2012 10:36 AM, Federico Vaga wrote: >> Thanks for your contribution. At a first glance, this driver looks >> similar to the pch_can and the c_can driver. It seems that a C_CAN based >> controller is used on that board as well. If that's true, it should be >> handled by the C_CAN driver. To get ride of the obsolete pch_can driver, >> I sent some time ago the patch "[RFC/PATCH] c_can: add driver for the >> PCH CAN controller": >> >> http://marc.info/?t=132991563600003&r=1&w=4 >> >> I could serve as base of a generic c_can_pci driver. > > You are right, this is a C-CAN but it isn't specified on the board manual. > I compared the board manual with the Bosch C-CAN manual, and it is the same. Like with the Intel EG20T PCH CAN controller. > I'm working on a PCI module for this board, when it is ready we can think for > a generic c_can_pci That would be nice, thanks. You might have realized that AnilKumar has provided support for the D_CAN controllers to the C_CAN driver which will show up mainline soon. Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/