Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752896Ab2E0QDt (ORCPT ); Sun, 27 May 2012 12:03:49 -0400 Received: from netrider.rowland.org ([192.131.102.5]:39930 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752740Ab2E0QD1 (ORCPT ); Sun, 27 May 2012 12:03:27 -0400 Date: Sun, 27 May 2012 12:03:26 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Michal Nazarewicz cc: Felipe Balbi , , , Subject: Re: [PATCH] usb: gadget: f_mass_storage: change default value of the removable parameter In-Reply-To: <9f033e3d3b2bcbdbf02253de540174479c0dd945.1338074060.git.mina86@mina86.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 27 On Sat, 26 May 2012, Michal Nazarewicz wrote: > This commit changes the default value of the removable module parameter > from “y” to “n”. This comes with line with file_storag's default and > seems to be a better default. > > Signed-off-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_mass_storage.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > Alternatively I can add a warning about the default being changed and > schedule the change for the future. Dunno if it's worth it. I think this patch is good as it stands. Would you like to write a gadget-mass-storage.txt file for Documentation/usb? Putting all the instructions for using the mass-storage gadget in a recognized place would help people to find it. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/