Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752520Ab2E0TNr (ORCPT ); Sun, 27 May 2012 15:13:47 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:58802 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778Ab2E0TNp (ORCPT ); Sun, 27 May 2012 15:13:45 -0400 X-Sasl-enc: oZm2UamHtGSo94kyOxIOcmbjgC5YAT544VLU1ILTbVg6 1338146025 Message-ID: <4FC27CE7.20604@fastmail.fm> Date: Sun, 27 May 2012 20:13:43 +0100 From: Jack Stone User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Eric Dumazet CC: davem@davemloft.net, netdev@vger.kernel.org, Linux Kernel Subject: Re: WARNING: at net/ipv4/tcp.c:1610 tcp_recvmsg+0xb1b/0xc70() References: <4FBFEACC.8040601@fastmail.fm> <1337978725.10135.0.camel@edumazet-glaptop> <1337979331.10135.2.camel@edumazet-glaptop> <4FC0BCE1.6070601@fastmail.fm> <1338127184.3670.50.camel@edumazet-glaptop> <4FC24987.4090708@fastmail.fm> <1338140156.3786.10.camel@edumazet-glaptop> In-Reply-To: <1338140156.3786.10.camel@edumazet-glaptop> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5913 Lines: 92 On 05/27/2012 06:35 PM, Eric Dumazet wrote: > So it seems we can queue in sk_receive_queue a packet with SYN flag set. > > (A SYN or SYNACK packet contains DATA payload...) > > The sequence number of such frames should be tweaked (seq++) instead of > games we do in fast path : > > if (tcp_hdr(skb)->syn) > offset--; > > > Oh well this can wait linux-3.6, please test following patch in the > meantime. > > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c > index b224eb8..34c8dcc 100644 > --- a/net/ipv4/tcp_input.c > +++ b/net/ipv4/tcp_input.c > @@ -4553,7 +4553,7 @@ static bool tcp_try_coalesce(struct sock *sk, > > *fragstolen = false; > > - if (tcp_hdr(from)->fin) > + if (tcp_hdr(from)->fin || tcp_hdr(to)->syn) > return false; > > /* Its possible this segment overlaps with prior segment in queue */ > > Still seems to fire with the above applied, it also sets of the warn just above it... Could it be something to do with my staging network driver? [ 2605.769938] ------------[ cut here ]------------ [ 2605.769942] WARNING: at net/ipv4/tcp.c:1611 tcp_recvmsg+0xb36/0xc90() [ 2605.769943] Hardware name: System Product Name [ 2605.769944] recvmsg bug 2: copied 84322A4D seq 84322A4D end_seq 84322A86 rcvnxt 843233B3 fl 0 offset 4294967295 len 57 syn 1 [ 2605.769982] Modules linked in: fuse ebtable_nat ebtables ipt_MASQUERADE iptable_nat nf_nat xt_CHECKSUM iptable_mangle bridge lockd rfcomm 8021q garp stp llc bnep ip6t_REJECT nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack ip6table_filter ip6_tables snd_hda_codec_hdmi snd_hda_codec_realtek vhost_net macvtap macvlan tun coretemp virtio_net kvm_intel kvm btusb bluetooth snd_hda_intel snd_hda_codec snd_hwdep snd_seq sunrpc r8712u(C) snd_seq_device snd_pcm snd_timer eeepc_wmi asus_wmi sparse_keymap e1000e mxm_wmi snd soundcore joydev wmi rfkill i2c_i801 snd_page_alloc iTCO_wdt serio_raw hid_logitech_dj pcspkr iTCO_vendor_support binfmt_misc microcode uinput crc32c_intel ghash_clmulni_intel firewire_ohci firewire_core crc_itu_t [last unloaded: scsi_wait_scan] [ 2605.769985] Pid: 3305, comm: firefox Tainted: G WC 3.4.0-07822-g786f02b-dirty #2 [ 2605.769986] Call Trace: [ 2605.769988] [] warn_slowpath_common+0x7f/0xc0 [ 2605.769990] [] warn_slowpath_fmt+0x46/0x50 [ 2605.769993] [] ? tcp_recvmsg+0x35/0xc90 [ 2605.769996] [] tcp_recvmsg+0xb36/0xc90 [ 2605.769998] [] ? inet_sendmsg+0x230/0x230 [ 2605.770001] [] inet_recvmsg+0x137/0x250 [ 2605.770004] [] ? sock_update_classid+0x128/0x310 [ 2605.770006] [] sock_recvmsg+0x11d/0x140 [ 2605.770009] [] ? fget_light+0x48/0x4f0 [ 2605.770012] [] ? __pollwait+0xf0/0xf0 [ 2605.770014] [] ? fget_light+0x106/0x4f0 [ 2605.770017] [] ? fget_light+0x48/0x4f0 [ 2605.770020] [] sys_recvfrom+0xf1/0x170 [ 2605.770022] [] ? __audit_syscall_entry+0xcc/0x310 [ 2605.770025] [] ? trace_hardirqs_on_thunk+0x3a/0x3f [ 2605.770028] [] system_call_fastpath+0x16/0x1b [ 2605.770029] ---[ end trace f86533e3bdc5b326 ]--- ------------[ cut here ]------------ [ 2605.770032] WARNING: at net/ipv4/tcp.c:1598 tcp_recvmsg+0x409/0xc90() [ 2605.770034] Hardware name: System Product Name [ 2605.770082] recvmsg bug: copied 84322A4D seq 84322A86 rcvnxt 843233B3 fl 0 [ 2605.770119] Modules linked in: fuse ebtable_nat ebtables ipt_MASQUERADE iptable_nat nf_nat xt_CHECKSUM iptable_mangle bridge lockd rfcomm 8021q garp stp llc bnep ip6t_REJECT nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv6 nf_defrag_ipv6 nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack ip6table_filter ip6_tables snd_hda_codec_hdmi snd_hda_codec_realtek vhost_net macvtap macvlan tun coretemp virtio_net kvm_intel kvm btusb bluetooth snd_hda_intel snd_hda_codec snd_hwdep snd_seq sunrpc r8712u(C) snd_seq_device snd_pcm snd_timer eeepc_wmi asus_wmi sparse_keymap e1000e mxm_wmi snd soundcore joydev wmi rfkill i2c_i801 snd_page_alloc iTCO_wdt serio_raw hid_logitech_dj pcspkr iTCO_vendor_support binfmt_misc microcode uinput crc32c_intel ghash_clmulni_intel firewire_ohci firewire_core crc_itu_t [last unloaded: scsi_wait_scan] [ 2605.770122] Pid: 3305, comm: firefox Tainted: G WC 3.4.0-07822-g786f02b-dirty #2 [ 2605.770123] Call Trace: [ 2605.770125] [] warn_slowpath_common+0x7f/0xc0 [ 2605.770128] [] warn_slowpath_fmt+0x46/0x50 [ 2605.770130] [] ? tcp_recvmsg+0x35/0xc90 [ 2605.770132] [] tcp_recvmsg+0x409/0xc90 [ 2605.770135] [] ? inet_sendmsg+0x230/0x230 [ 2605.770138] [] inet_recvmsg+0x137/0x250 [ 2605.770140] [] ? sock_update_classid+0x128/0x310 [ 2605.770143] [] sock_recvmsg+0x11d/0x140 [ 2605.770146] [] ? fget_light+0x48/0x4f0 [ 2605.770148] [] ? __pollwait+0xf0/0xf0 [ 2605.770150] [] ? fget_light+0x106/0x4f0 [ 2605.770152] [] ? fget_light+0x48/0x4f0 [ 2605.770154] [] sys_recvfrom+0xf1/0x170 [ 2605.770157] [] ? __audit_syscall_entry+0xcc/0x310 [ 2605.770160] [] ? trace_hardirqs_on_thunk+0x3a/0x3f [ 2605.770163] [] system_call_fastpath+0x16/0x1b [ 2605.770164] ---[ end trace f86533e3bdc5b327 ]--- Thanks, Jack -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/