Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292Ab2E0U7I (ORCPT ); Sun, 27 May 2012 16:59:08 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:33738 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195Ab2E0U7E convert rfc822-to-8bit (ORCPT ); Sun, 27 May 2012 16:59:04 -0400 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Alan Stern" Cc: "Felipe Balbi" , panto@antoniou-consulting.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: f_mass_storage: change default value of the removable parameter References: Date: Sun, 27 May 2012 13:59:00 -0700 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: User-Agent: Opera Mail/11.64 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 32 > On Sat, 26 May 2012, Michal Nazarewicz wrote: >> This commit changes the default value of the removable module parameter >> from “y” to “n”. This comes with line with file_storag's default and >> seems to be a better default. >> >> Signed-off-by: Michal Nazarewicz >> --- >> drivers/usb/gadget/f_mass_storage.c | 6 ++---- >> 1 files changed, 2 insertions(+), 4 deletions(-) >> >> Alternatively I can add a warning about the default being changed and >> schedule the change for the future. Dunno if it's worth it. On Sun, 27 May 2012 09:03:26 -0700, Alan Stern wrote: > I think this patch is good as it stands. > > Would you like to write a gadget-mass-storage.txt file for > Documentation/usb? Putting all the instructions for using the > mass-storage gadget in a recognized place would help people to find it. Sure. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/