Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752420Ab2E1BVY (ORCPT ); Sun, 27 May 2012 21:21:24 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:40903 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941Ab2E1BVW (ORCPT ); Sun, 27 May 2012 21:21:22 -0400 Date: Mon, 28 May 2012 10:21:07 +0900 From: Tejun Heo To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, agk@redhat.com, neilb@suse.de, drbd-dev@lists.linbit.com, bharrosh@panasas.com, vgoyal@redhat.com, mpatocka@redhat.com, sage@newdream.net, yehuda@hq.newdream.net Subject: Re: [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info Message-ID: <20120528012107.GB9891@dhcp-172-17-108-109.mtv.corp.google.com> References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-3-git-send-email-koverstreet@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337977539-16977-3-git-send-email-koverstreet@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 600 Lines: 15 On Fri, May 25, 2012 at 01:25:25PM -0700, Kent Overstreet wrote: > Previously, dm_rq_clone_bio_info needed to be freed by the bio's > destructor to avoid a memory leak in the blk_rq_prep_clone() error path. > This gets rid of a memory allocation and means we can kill > dm_rq_bio_destructor. To what goal are we doing this? How is it tested? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/