Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726Ab2E1Bg0 (ORCPT ); Sun, 27 May 2012 21:36:26 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:36271 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751067Ab2E1BgY (ORCPT ); Sun, 27 May 2012 21:36:24 -0400 Date: Mon, 28 May 2012 10:36:08 +0900 From: Tejun Heo To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, agk@redhat.com, neilb@suse.de, drbd-dev@lists.linbit.com, bharrosh@panasas.com, vgoyal@redhat.com, mpatocka@redhat.com, sage@newdream.net, yehuda@hq.newdream.net Subject: Re: [PATCH v3 05/16] block: Kill bi_destructor Message-ID: <20120528013608.GE9891@dhcp-172-17-108-109.mtv.corp.google.com> References: <1337977539-16977-1-git-send-email-koverstreet@google.com> <1337977539-16977-6-git-send-email-koverstreet@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337977539-16977-6-git-send-email-koverstreet@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1243 Lines: 32 On Fri, May 25, 2012 at 01:25:28PM -0700, Kent Overstreet wrote: > Now that we've got generic code for freeing bios allocated from bio > pools, this isn't needed anymore. > > This also changes the semantics of bio_free() a bit - it now also frees > bios allocated by bio_kmalloc(). It's also no longer exported, as > without bi_destructor there should be no need for it to be called > anywhere else. I like this patch but I'd *really* like to see the patch description giving some background and explains *why* this is a good change. > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index 6b7daf3..b6ddbf1 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -74,11 +74,8 @@ struct bio { > struct bio_integrity_payload *bi_integrity; /* data integrity */ > #endif > > - /* If bi_pool is non NULL, bi_destructor is not called */ > struct bio_set *bi_pool; Maybe explain that %NULL bi_pool indicates kmalloc backed allocation? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/