Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752131Ab2E1EX0 (ORCPT ); Mon, 28 May 2012 00:23:26 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:55735 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279Ab2E1EXZ convert rfc822-to-8bit (ORCPT ); Mon, 28 May 2012 00:23:25 -0400 MIME-Version: 1.0 In-Reply-To: <1338172734.977.3.camel@joe2Laptop> References: <1338152074-30747-1-git-send-email-devendra.aaru@gmail.com> <1338172734.977.3.camel@joe2Laptop> Date: Mon, 28 May 2012 09:53:24 +0530 Message-ID: Subject: Re: [PATCH] [staging] bcm: Fix codingstyle problems From: "devendra.aaru" To: Joe Perches Cc: Kevin McKinney , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 31 Hello Joe, On Mon, May 28, 2012 at 8:08 AM, Joe Perches wrote: > On Sun, 2012-05-27 at 22:30 -0400, Kevin McKinney wrote: >> Hi Devendra, >> >> On Sun, May 27, 2012 at 4:54 PM, Devendra Naga wrote: >> > Signed-off-by: Devendra Naga >> > --- >> > ?drivers/staging/bcm/Debug.h | ? ?6 +++--- >> > ?1 file changed, 3 insertions(+), 3 deletions(-) >> > >> I understand this is a simple change, but please add a descriptive >> change log to your patch for consistency. > > Hello as well. > > Devendra, sometimes the simpler change isn't the best change. > Consider converting some of these macros into functions. > So How about converting BCM_DEBUG_PRINT, BCM_DEBUG_PRINT_BUFFER, BCM_SHOW_DEBUG_BITMAP into a single function? and using a type to print the corresponding values? > Thanks, Devendra. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/