Message-ID: <1338217956.2202.27.camel@joe2Laptop>
Subject: Re: [PATCH V3] checkpatch: check for whitespace before semicolon at
 EOL
From: Joe Perches <joe@perches.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Eric Nelson <eric.nelson@boundarydevices.com>, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Date: Mon, 28 May 2012 08:12:36 -0700
In-Reply-To: <20120528144259.GA5878@dm>
References: <1338163246-6727-1-git-send-email-eric.nelson@boundarydevices.com>
	 <20120528144259.GA5878@dm>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 712
Lines: 19

On Mon, 2012-05-28 at 15:42 +0100, Andy Whitcroft wrote:
> On Sun, May 27, 2012 at 05:00:46PM -0700, Eric Nelson wrote:
> > +# check for whitespace before a non-naked semicolon
> > +		if ($line =~ /^\+.*\S\s+;/) {
> > +			CHK("SPACING",
> > +			    "space prohibited before semicolon\n" . $herecurr);
> > +		}
> > +
> 
> Would this not also falsly trigger on 'for (foo = 10; foo; foo--) {' ?

No, it checks for a non-space, then requires whitespace before the semi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/