Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754910Ab2E1TWW (ORCPT ); Mon, 28 May 2012 15:22:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21195 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754389Ab2E1TWV (ORCPT ); Mon, 28 May 2012 15:22:21 -0400 Date: Mon, 28 May 2012 21:21:57 +0200 From: Jiri Olsa To: Ulrich Drepper Cc: Andi Kleen , acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu, paulus@samba.org, cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com, linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [RFCv2 0/8] perf tool: Add new event group management Message-ID: <20120528192157.GD9654@m.brq.redhat.com> References: <1333574176-11388-1-git-send-email-jolsa@redhat.com> <20120525223646.GL27374@one.firstfloor.org> <20120526123858.GA1679@m.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1847 Lines: 44 On Sun, May 27, 2012 at 03:56:22AM -0400, Ulrich Drepper wrote: > On Sat, May 26, 2012 at 8:38 AM, Jiri Olsa wrote: > > If you have some ideas on this or real world examples, > > that would really help.. so far, here's the latest discussion: > > http://marc.info/?t=133357436900005&r=1&w=2 > > If you're looking for a definitive source, just point to the Intel > optimization manual. Absolute values of counters are not really > useful and so they are defining many (50+) ratios which people should > investigate. These ratios are only really accurate if the counters > are swapped in and out at the same time. thanks a lot for the pointer, very useful > > The reminds me of a detail I looked at when starting an an > implementation for this (glad you got more time to devote to it). The > problem with ratios are that there are so many. So efficient > scheduling is going to be important. Many ratios use as a base the > same counters over and over again (e.g., cycle count, instruction > count, etc). Therefore it is important to recognize when two groups > can be scheduled concurrently even if the total number of counters > needed would be high but due to intersections it is possible. > > One last comment, not critical. From a parsing point of view the > colon in the proposed syntax > > name : { counter1, counter2 } > > is unnecessary. Just one more thing people can get wrong. How about > leaving it out? An open curly brace to indicate a group should be > sufficient. yep, we'll omit the first colon I'll CC you guys on next patchset thanks, jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/