Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752917Ab2E2JG2 (ORCPT ); Tue, 29 May 2012 05:06:28 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:46843 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751641Ab2E2JG1 (ORCPT ); Tue, 29 May 2012 05:06:27 -0400 Date: Tue, 29 May 2012 10:06:14 +0100 From: Russell King - ARM Linux To: Sam Ravnborg Cc: Vincent Sanders , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Morton , Arnd Bergmann , Vincent Sanders Subject: Re: [PATCH 1/2] Allow constructor name selection by architecture. Message-ID: <20120529090614.GD12217@n2100.arm.linux.org.uk> References: <1338230018-31052-1-git-send-email-vincent.sanders@collabora.co.uk> <1338230018-31052-2-git-send-email-vincent.sanders@collabora.co.uk> <20120528203005.GA20560@merkur.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120528203005.GA20560@merkur.ravnborg.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1729 Lines: 42 On Mon, May 28, 2012 at 10:30:05PM +0200, Sam Ravnborg wrote: > On Mon, May 28, 2012 at 07:33:37PM +0100, Vincent Sanders wrote: > > From: Vincent Sanders > > > > The constructor symbol name is different between platforms. Allow this > > to be selected by configuration and set suitable default values. > > > > Signed-off-by: Vincent Sanders > > --- > > include/asm-generic/vmlinux.lds.h | 6 +++--- > > init/Kconfig | 6 ++++++ > > kernel/module.c | 2 +- > > 3 files changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > > index 8aeadf6..fd34808 100644 > > --- a/include/asm-generic/vmlinux.lds.h > > +++ b/include/asm-generic/vmlinux.lds.h > > @@ -471,9 +471,9 @@ > > } > > > > #ifdef CONFIG_CONSTRUCTORS > > -#define KERNEL_CTORS() . = ALIGN(8); \ > > - VMLINUX_SYMBOL(__ctors_start) = .; \ > > - *(.ctors) \ > > +#define KERNEL_CTORS() . = ALIGN(8); \ > > + VMLINUX_SYMBOL(__ctors_start) = .; \ > > + *(CONFIG_CONSTRUCTORS_NAME) \ > > VMLINUX_SYMBOL(__ctors_end) = .; > > What is wrong with adding both "standard" names for ctors uncnditionally? > Like this: > > *(.ctors) \ > > + *(.init_array) \ That doesn't get rid of CONFIG_CONSTRUCTORS_NAME, because it's needed in the module code. Do you have a suggestion to solve that as well? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/