Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666Ab2E2Lhz (ORCPT ); Tue, 29 May 2012 07:37:55 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:10841 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536Ab2E2Lhy (ORCPT ); Tue, 29 May 2012 07:37:54 -0400 X-IronPort-AV: E=McAfee;i="5400,1158,6725"; a="193186731" Message-ID: In-Reply-To: <009d01cd3411$0febc350$2fc349f0$%jun@samsung.com> References: <009d01cd3411$0febc350$2fc349f0$%jun@samsung.com> Date: Tue, 29 May 2012 04:37:54 -0700 (PDT) Subject: Re: [PATCH v6 1/3] mmc: core: Add packed command feature of eMMC4.5 From: merez@codeaurora.org To: "Seungwon Jeon" Cc: linux-mmc@vger.kernel.org, "'Chris Ball'" , merez@codeaurora.org, linux-kernel@vger.kernel.org User-Agent: SquirrelMail/1.4.17 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 37 > @@ -1244,6 +1249,25 @@ static int mmc_init_card(struct mmc_host *host, u32 > ocr, > } > } > > + if ((host->caps2 & MMC_CAP2_PACKED_CMD) && > + (card->ext_csd.max_packed_writes > 0) && > + (card->ext_csd.max_packed_reads > 0)) { > + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, > + EXT_CSD_EXP_EVENTS_CTRL, > + EXT_CSD_PACKED_EVENT_EN, > + card->ext_csd.generic_cmd6_time); > + if (err && err != -EBADMSG) > + goto free_card; > + if (err) { > + pr_warning("%s: Enabling packed event failed\n", > + mmc_hostname(card->host)); > + card->ext_csd.packed_event_en = 0; > + err = 0; > + } else { > + card->ext_csd.packed_event_en = 1; > + } > + } > + The above shoud not be performed in case of resume. Therefore it needs to be done only if (!oldcard) Thanks, Maya Erez Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/