Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819Ab2E2Rwc (ORCPT ); Tue, 29 May 2012 13:52:32 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:38739 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754545Ab2E2Rwb (ORCPT ); Tue, 29 May 2012 13:52:31 -0400 Message-ID: <4FC50CCD.7090404@ti.com> Date: Tue, 29 May 2012 12:52:13 -0500 From: Jon Hunter User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: CC: , , , , , , , , , , , Subject: Re: [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4 References: <1337942552-28218-1-git-send-email-jgq516@gmail.com> <1337942552-28218-2-git-send-email-jgq516@gmail.com> In-Reply-To: <1337942552-28218-2-git-send-email-jgq516@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.157.144.139] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1824 Lines: 64 On 05/25/2012 05:42 AM, jgq516@gmail.com wrote: > From: Xiao Jiang > > Add wdt node to support dt. > > Signed-off-by: Xiao Jiang > --- > arch/arm/boot/dts/omap3.dtsi | 5 +++++ > arch/arm/boot/dts/omap4.dtsi | 5 +++++ > 2 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi > index 99474fa..039df5c 100644 > --- a/arch/arm/boot/dts/omap3.dtsi > +++ b/arch/arm/boot/dts/omap3.dtsi > @@ -215,5 +215,10 @@ > compatible = "ti,omap3-hsmmc"; > ti,hwmods = "mmc3"; > }; > + > + wdt: wdt@48314000{ Minor comment, may be call this wdt2 as this is watchdog timer 2. Also ass a space between the address and the "{". > + compatible = "ti,omap3-wdt"; > + ti,hwmods = "wd_timer2"; > + }; > }; > }; > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index 359c497..d01403d 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -272,5 +272,10 @@ > ti,hwmods = "mmc5"; > ti,needs-special-reset; > }; > + > + wdt: wdt@4a314000{ Same as above. > + compatible = "ti,omap4-wdt"; > + ti,hwmods = "wd_timer2"; > + }; > }; > }; Also we should add some documentation to describe the binding. Here it is very simple, but nonetheless we should have something as we have for gpio [1]. Cheers Jon [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/devicetree/bindings/gpio/gpio-omap.txt;h=bff51a2fee1eae7d387b40ea913e04782554bf68;hb=HEAD -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/