Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754933Ab2E2SQQ (ORCPT ); Tue, 29 May 2012 14:16:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32985 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754694Ab2E2SQP (ORCPT ); Tue, 29 May 2012 14:16:15 -0400 Date: Tue, 29 May 2012 20:15:02 +0200 From: Andrea Arcangeli To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Rik van Riel , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter Subject: Re: [PATCH 08/35] autonuma: introduce kthread_bind_node() Message-ID: <20120529181502.GM21339@redhat.com> References: <1337965359-29725-1-git-send-email-aarcange@redhat.com> <1337965359-29725-9-git-send-email-aarcange@redhat.com> <1338295753.26856.60.camel@twins> <20120529161157.GE21339@redhat.com> <1338311091.26856.146.camel@twins> <20120529174423.GK21339@redhat.com> <1338313686.26856.164.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1338313686.26856.164.camel@twins> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1447 Lines: 29 On Tue, May 29, 2012 at 07:48:06PM +0200, Peter Zijlstra wrote: > On Tue, 2012-05-29 at 19:44 +0200, Andrea Arcangeli wrote: > > > > But it'd be totally bad not to do the hard bindings to the cpu_s_ of > > the node, and not using PF_THREAD_BOUND would just allow userland to > > shoot itself in the foot. I mean if PF_THREAD_BOUND wouldn't exist > > already I wouldn't add it, but considering somebody bothered to > > implement it for the sake to make userland root user "safer", it'd be > > really silly not to take advantage of that for knuma_migrated too > > (even if it binds to more than 1 CPU). > > No, I'm absolutely ok with the user shooting himself in the foot. The > thing exists because you can crash stuff if you get it wrong with > per-cpu. > > Crashing is not good, worse performance is his own damn fault. Some people don't like root to write to /dev/mem or rm -r / either. I'm not in that camp, but if you're not in that camp, then you should _never_ care to set PF_THREAD_BOUND, no matter if it's about crashing or just slowing down the kernel. If such a thing exists, well using it to avoid the user either to crash or to screw with the system performance, can only be a bonus. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/