From: Seungwon Jeon <tgih.jun@samsung.com>
To: merez@codeaurora.org
Cc: linux-mmc@vger.kernel.org, "'Chris Ball'" <cjb@laptop.org>,
        linux-kernel@vger.kernel.org
References: <009d01cd3411$0febc350$2fc349f0$%jun@samsung.com>
 <d98d78ec2312cbc5edb1b2c337ab788d.squirrel@www.codeaurora.org>
In-reply-to: <d98d78ec2312cbc5edb1b2c337ab788d.squirrel@www.codeaurora.org>
Subject: RE: [PATCH v6 1/3] mmc: core: Add packed command feature of eMMC4.5
Date: Wed, 30 May 2012 09:20:34 +0900
Message-id: <001d01cd3dfa$07f83dc0$17e8b940$%jun@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
Thread-index: Ac09j4vgcnVcL5NRTyiy6BQNVHElOAAaAQJA
Content-language: ko
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1533
Lines: 47

Maya Erez <merez@codeaurora.org> wrote:
> > @@ -1244,6 +1249,25 @@ static int mmc_init_card(struct mmc_host *host, u32
> > ocr,
> >  		}
> >  	}
> >
> > +	if ((host->caps2 & MMC_CAP2_PACKED_CMD) &&
> > +			(card->ext_csd.max_packed_writes > 0) &&
> > +			(card->ext_csd.max_packed_reads > 0)) {
> > +		err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> > +				EXT_CSD_EXP_EVENTS_CTRL,
> > +				EXT_CSD_PACKED_EVENT_EN,
> > +				card->ext_csd.generic_cmd6_time);
> > +		if (err && err != -EBADMSG)
> > +			goto free_card;
> > +		if (err) {
> > +			pr_warning("%s: Enabling packed event failed\n",
> > +					mmc_hostname(card->host));
> > +			card->ext_csd.packed_event_en = 0;
> > +			err = 0;
> > +		} else {
> > +			card->ext_csd.packed_event_en = 1;
> > +		}
> > +	}
> > +
> The above shoud not be performed in case of resume. Therefore it needs to
> be done only if (!oldcard)
Could you explain the reason for this?

Thanks,
Seungwon Jeon
> 
> Thanks,
> Maya Erez
> Consultant for Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/