Message-ID: <1338354377.2361.13.camel@obelisk.thedillows.org>
Subject: Re: [PATCH 1/1] ib_srp: Infiniband srp fast failover patch.
From: David Dillow <dillowda@ornl.gov>
To: Karandeep Chahal <kchahal@ddn.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        roland@kernel.org, sean.hefty@intel.com
Date: Wed, 30 May 2012 01:06:17 -0400
In-Reply-To: <4FC53AAA.3060203@ddn.com>
References: <4FC53AAA.3060203@ddn.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1120
Lines: 28

On Tue, 2012-05-29 at 17:07 -0400, Karandeep Chahal wrote:
> Subject: [PATCH] Infiniband srp fast failover patch.

This conflicts with Bart's patches to improve failover; it will be much
better to use his approach to block the target rather than remove it
wholesale -- we could have lost connectivity as a transient and may get
it back quickly if someone grabbed the wrong cable, etc.

Also, we should only kill the one target on DREQ, and we already have a
pointer to it from the CM context -- no need to search.

It is a good idea to hook into the event mechanism; this is something
I've long wanted to incorporate (as Vu did in OFED). I'm looking at
getting Bart's series to a point I can merge it, and I'll pull in your
ideas -- with credit -- there.

Thanks,
-- 
Dave Dillow
National Center for Computational Science
Oak Ridge National Laboratory
(865) 241-6602 office

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/