Message-ID: <4FC5C55E.9000909@hitachi.com>
Date: Wed, 30 May 2012 15:59:42 +0900
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Organization: Hitachi, Ltd., Japan
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        "Frank Ch. Eigler" <fche@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        yrl.pp-manager.tt@hitachi.com
Subject: Re: [RFC PATCH -tip  0/9]ftrace, kprobes: Ftrace-based kprobe optimization
References: <20120529124833.9191.23007.stgit@localhost.localdomain> <1338331514.13348.298.camel@gandalf.stny.rr.com>
In-Reply-To: <1338331514.13348.298.camel@gandalf.stny.rr.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1348
Lines: 33

(2012/05/30 7:45), Steven Rostedt wrote:
> On Tue, 2012-05-29 at 21:48 +0900, Masami Hiramatsu wrote:
> 
>> Also, this makes all __kprobes functions "notrace", because
>> some of those functions are considered as to be called from
>> kprobes handler which is called from function tracer.
>> I think that is another discussion point. Perhaps, we need
>> to introduce another tag which means "don't put kprobe on
>> this function" instead of __kprobes and apply that.
> 
> Actually, instead, we can force kprobes to have all "__kprobes"
> functions added to its 'notrace' ftrace_ops. This will just keep kprobes
> from function tracing these, as I find myself tracing functions marked
> by kprobes quite a bit.

Hmm, I'm not so sure how the notrace and filter works.
What happens if I set a foo function-entry on filter
and keep notrace empty?
 - only foo's nop is replaced with call?
 - or all functions including foo is traced?

Thank you,

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/