Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752291Ab2E3K3e (ORCPT ); Wed, 30 May 2012 06:29:34 -0400 Received: from casper.infradead.org ([85.118.1.10]:43083 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098Ab2E3K3d convert rfc822-to-8bit (ORCPT ); Wed, 30 May 2012 06:29:33 -0400 Message-ID: <1338373759.26856.238.camel@twins> Subject: Re: [PATCH v3 1/6] measure exec_clock for rt sched entities From: Peter Zijlstra To: Glauber Costa Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, devel@openvz.org, Paul Turner , Tejun Heo , "Eric W. Biederman" , handai.szj@gmail.com, Andrew.Phillips@lmax.com, Serge Hallyn Date: Wed, 30 May 2012 12:29:19 +0200 In-Reply-To: <1338371317-5980-2-git-send-email-glommer@parallels.com> References: <1338371317-5980-1-git-send-email-glommer@parallels.com> <1338371317-5980-2-git-send-email-glommer@parallels.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 42 On Wed, 2012-05-30 at 13:48 +0400, Glauber Costa wrote: > For simetry with the cfq tasks, measure exec_clock for the rt > sched entities (rt_se). Symmetry methinks.. anyway, where is the symmetry?, fair.c:update_curr() doesn't do the for_each_sched_entity() thing. > This can be used in a number of fashions. For instance, to > compute total cpu usage in a cgroup that is generated by > rt tasks. > > Signed-off-by: Glauber Costa > CC: Peter Zijlstra > CC: Paul Turner > --- > kernel/sched/rt.c | 5 +++++ > kernel/sched/sched.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c > index c5565c3..30ee4e2 100644 > --- a/kernel/sched/rt.c > +++ b/kernel/sched/rt.c > @@ -919,6 +919,11 @@ static void update_curr_rt(struct rq *rq) > > sched_rt_avg_update(rq, delta_exec); > > + for_each_sched_rt_entity(rt_se) { > + rt_rq = rt_rq_of_se(rt_se); > + schedstat_add(rt_rq, exec_clock, delta_exec); > + } > + > if (!rt_bandwidth_enabled()) > return; See, this just makes me sad.. you now have a double for_each_sched_rt_entity() loop. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/