Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494Ab2E3Kip (ORCPT ); Wed, 30 May 2012 06:38:45 -0400 Received: from mx2.parallels.com ([64.131.90.16]:44967 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283Ab2E3Kio (ORCPT ); Wed, 30 May 2012 06:38:44 -0400 Message-ID: <4FC5F82B.6030404@parallels.com> Date: Wed, 30 May 2012 14:36:27 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Peter Zijlstra CC: , , , Paul Turner , Tejun Heo , "Eric W. Biederman" , , , Serge Hallyn Subject: Re: [PATCH v3 2/6] account guest time per-cgroup as well. References: <1338371317-5980-1-git-send-email-glommer@parallels.com> <1338371317-5980-3-git-send-email-glommer@parallels.com> <1338373947.26856.240.camel@twins> In-Reply-To: <1338373947.26856.240.camel@twins> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1073 Lines: 22 On 05/30/2012 02:32 PM, Peter Zijlstra wrote: > On Wed, 2012-05-30 at 13:48 +0400, Glauber Costa wrote: >> > We already track multiple tick statistics per-cgroup, using >> > the task_group_account_field facility. This patch accounts >> > guest_time in that manner as well. > So this leaves IOWAIT and IDLE the only fields not using > task_group_account_field(), right? Yes, because they are essentially global, and their meaning is ill-defined from within a cgroup. If you look further out in the patchset, I intend to export idle from cpu, instead of cpuacct, because something that can be used as idle value is already computed anyway from the schedstats, so I'm just using it. iowait will be left blank for now. Me and Paul agreed last time we talked that it is not uber important to have iowait values per-cgroup. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/