Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753981Ab2E3Myu (ORCPT ); Wed, 30 May 2012 08:54:50 -0400 Received: from mx2.parallels.com ([64.131.90.16]:54114 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784Ab2E3Myr (ORCPT ); Wed, 30 May 2012 08:54:47 -0400 Message-ID: <4FC6180F.9020009@parallels.com> Date: Wed, 30 May 2012 16:52:31 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Paul Turner CC: , , , Peter Zijlstra , Tejun Heo , "Eric W. Biederman" , , , Serge Hallyn Subject: Re: [PATCH v3 3/6] expose fine-grained per-cpu data for cpuacct stats References: <1338371317-5980-1-git-send-email-glommer@parallels.com> <1338371317-5980-4-git-send-email-glommer@parallels.com> <4FC6107F.9020802@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1224 Lines: 29 On 05/30/2012 04:48 PM, Paul Turner wrote: > a) the information in /proc/stat is actually much denser since it's > "cpu VAL VAL VAL VAL" as opposed to "cpuX.FIELD VAL" easily fixable here. Less descriptive, but we can use a header line with the description much like how /proc/slabinfo does, and we still have an extensible interface that is dense, at the same time. > b) If it became a problem the /proc/stat case is actually fairly > trivially fixable by defining each cpu as a record and "everything > else" as a magic im-out-of-cpus value. > >> > >> > Now, if you guys are okay with a file per-cpu, I can do it as well. >> > It pollutes the filesystem, but at least protects against the fact that this >> > is kmalloc-backed. >> > > As I prefaced, I'm not sure there's much that can be trivially done > about it. This is really a fundamental limitation of how read_map() > works. > > What we really need is a proper seq_file exposed through cftypes. That can be done. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/