Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754828Ab2E3OOB (ORCPT ); Wed, 30 May 2012 10:14:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17516 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754604Ab2E3OOA (ORCPT ); Wed, 30 May 2012 10:14:00 -0400 Date: Wed, 30 May 2012 15:49:53 +0200 From: Andrea Arcangeli To: Peter Zijlstra Cc: KOSAKI Motohiro , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter Subject: Re: [PATCH 13/35] autonuma: add page structure fields Message-ID: <20120530134953.GD21339@redhat.com> References: <1337965359-29725-1-git-send-email-aarcange@redhat.com> <1337965359-29725-14-git-send-email-aarcange@redhat.com> <1338297385.26856.74.camel@twins> <4FC4D58A.50800@redhat.com> <1338303251.26856.94.camel@twins> <4FC5D973.3080108@gmail.com> <1338368763.26856.207.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1338368763.26856.207.camel@twins> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 21 On Wed, May 30, 2012 at 11:06:03AM +0200, Peter Zijlstra wrote: > The trouble with making this per pmd is that you then get the false > sharing per pmd, so if there's shared data on the 2m page you'll not > know where to put it. The numa hinting page fault is already scanning the pmd only, and it's working fine. So reducing the page_autonuma to one per pmd would not reduce the granularity of the information with the default settings everyone has been using so far, but then it would prevent this runtime tweak to work: echo 0 >/sys/kernel/mm/autonuma/knuma_scand/pmd I'm thinking about it but probably reducing the page_autonuma to one per pmd is going to be the simplest solution considering by default we only track the pmd anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/