Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756117Ab2E3RVx (ORCPT ); Wed, 30 May 2012 13:21:53 -0400 Received: from mga03.intel.com ([143.182.124.21]:48333 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756071Ab2E3RVu convert rfc822-to-8bit (ORCPT ); Wed, 30 May 2012 13:21:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="149580951" From: "Liu, Jinsong" To: Borislav Petkov CC: Konrad Rzeszutek Wilk , "'linux-kernel@vger.kernel.org'" , "Luck, Tony" , "'xen-devel@lists.xensource.com'" Subject: RE: [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (RFC) Thread-Topic: [PATCH 1/3] xen/mce: Add mcelog support for Xen platform (RFC) Thread-Index: AQHNPoiwGrw1RQ/LHECPexwcwXKY3Q== Date: Wed, 30 May 2012 17:21:47 +0000 Message-ID: References: <20120524184947.GA28338@phenom.dumpdata.com> <20120525180102.GA27280@phenom.dumpdata.com> <20120529133858.GD29157@aftab.osrc.amd.com> <20120530150827.GA12109@phenom.dumpdata.com> <20120530152948.GD4771@aftab.osrc.amd.com> In-Reply-To: <20120530152948.GD4771@aftab.osrc.amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 47 Borislav Petkov wrote: > On Wed, May 30, 2012 at 03:20:03PM +0000, Liu, Jinsong wrote: >>>> IMO currently there are 2 options: >>>> 1). use the original approach (implicitly redirect /dev/mcelog to >>>> xen_mce_chrdev_device) --> what point of this approach do you think >>>> unreasonable? It just remove a 'static' from native mce code! 2). >>>> use another /dev/xen-mcelog interface, with another misc minor >>>> '226' >>> >>> The 2) is no good. >>> >>> 3) What about moving the corresponding other users (so >>> threshold_init_device), to be at late_initcall and the mce to be at >>> late_initcall_sync >> >> I can try, but only if Boris would not jump out. >> and it can only be tested by Boris at AMD platform :( > > Sure, I'll test it. > > However, it should be a separate patch, not merged with this one. > > So, I don't see anything speaking against making > threshold_init_device a late_initcall leading to the following order: > > device_initcall <- xen > device_initcall_sync <- arch/x86 > fs_initcall <- threshold_init_device do you mean 'late_initcall <- threshold_init_device'? > > and the "xen" line not happening on baremetal; which shouldn't change > anything noticeably in the init-order mce-wise. > > Also, add a comment at the end of mce_amd.c saying why > threshold_init_device should be last. > OK, good, we will use this approach, I will do it tomorrow morning. Thanks Konrad and Boris's suggestion! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/