Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757235Ab2E3R6q (ORCPT ); Wed, 30 May 2012 13:58:46 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:51407 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753245Ab2E3R6p (ORCPT ); Wed, 30 May 2012 13:58:45 -0400 MIME-Version: 1.0 In-Reply-To: <1338038429-21945-4-git-send-email-anton.vorontsov@linaro.org> References: <20120526131747.GA15054@lizard> <1338038429-21945-4-git-send-email-anton.vorontsov@linaro.org> Date: Wed, 30 May 2012 10:58:43 -0700 X-Google-Sender-Auth: 1g0OmvuEY_fyra33PViHWVtSfWw Message-ID: Subject: Re: [PATCH 04/11] pstore/ram: Factor ramoops_get_next_prz() out of ramoops_pstore_read() From: Kees Cook To: Anton Vorontsov Cc: Greg Kroah-Hartman , Colin Cross , Tony Luck , Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 19 On Sat, May 26, 2012 at 6:20 AM, Anton Vorontsov wrote: > This will help make code clearer when we'll add support for other > message types. > > The patch also changes return value from -EINVAL to 0 in case of > end-of-records. The exact value doesn't matter for pstore (it should > be just <= 0), but 0 feels more correct. Acked-by: Kees Cook -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/