Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754937Ab2E3U0T (ORCPT ); Wed, 30 May 2012 16:26:19 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:62849 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754848Ab2E3U0P (ORCPT ); Wed, 30 May 2012 16:26:15 -0400 Date: Wed, 30 May 2012 16:26:10 -0400 From: Konrad Rzeszutek Wilk To: Andrea Arcangeli Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Peter Zijlstra , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Rik van Riel , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter Subject: Re: [PATCH 08/35] autonuma: introduce kthread_bind_node() Message-ID: <20120530202610.GC30148@localhost.localdomain> References: <1337965359-29725-1-git-send-email-aarcange@redhat.com> <1337965359-29725-9-git-send-email-aarcange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337965359-29725-9-git-send-email-aarcange@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2845 Lines: 74 On Fri, May 25, 2012 at 07:02:12PM +0200, Andrea Arcangeli wrote: > This function makes it easy to bind the per-node knuma_migrated > threads to their respective NUMA nodes. Those threads take memory from > the other nodes (in round robin with a incoming queue for each remote > node) and they move that memory to their local node. > > Signed-off-by: Andrea Arcangeli > --- > include/linux/kthread.h | 1 + > kernel/kthread.c | 23 +++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 0 deletions(-) > > diff --git a/include/linux/kthread.h b/include/linux/kthread.h > index 0714b24..e733f97 100644 > --- a/include/linux/kthread.h > +++ b/include/linux/kthread.h > @@ -33,6 +33,7 @@ struct task_struct *kthread_create_on_node(int (*threadfn)(void *data), > }) > > void kthread_bind(struct task_struct *k, unsigned int cpu); > +void kthread_bind_node(struct task_struct *p, int nid); > int kthread_stop(struct task_struct *k); > int kthread_should_stop(void); > bool kthread_freezable_should_stop(bool *was_frozen); > diff --git a/kernel/kthread.c b/kernel/kthread.c > index 3d3de63..48b36f9 100644 > --- a/kernel/kthread.c > +++ b/kernel/kthread.c > @@ -234,6 +234,29 @@ void kthread_bind(struct task_struct *p, unsigned int cpu) > EXPORT_SYMBOL(kthread_bind); > > /** > + * kthread_bind_node - bind a just-created kthread to the CPUs of a node. > + * @p: thread created by kthread_create(). > + * @nid: node (might not be online, must be possible) for @k to run on. > + * > + * Description: This function is equivalent to set_cpus_allowed(), > + * except that @nid doesn't need to be online, and the thread must be > + * stopped (i.e., just returned from kthread_create()). > + */ > +void kthread_bind_node(struct task_struct *p, int nid) > +{ > + /* Must have done schedule() in kthread() before we set_task_cpu */ > + if (!wait_task_inactive(p, TASK_UNINTERRUPTIBLE)) { > + WARN_ON(1); > + return; > + } > + > + /* It's safe because the task is inactive. */ > + do_set_cpus_allowed(p, cpumask_of_node(nid)); > + p->flags |= PF_THREAD_BOUND; > +} > +EXPORT_SYMBOL(kthread_bind_node); _GPL? > + > +/** > * kthread_stop - stop a thread created by kthread_create(). > * @k: thread created by kthread_create(). > * > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/