Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756061Ab2E3U4T (ORCPT ); Wed, 30 May 2012 16:56:19 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:34406 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753750Ab2E3U4R (ORCPT ); Wed, 30 May 2012 16:56:17 -0400 Date: Wed, 30 May 2012 21:56:13 +0100 From: Al Viro To: Linus Torvalds Cc: Eric Paris , Mimi Zohar , Mimi Zohar , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfs: fix IMA lockdep circular locking dependency Message-ID: <20120530205612.GY11775@ZenIV.linux.org.uk> References: <20120516004251.GO22082@ZenIV.linux.org.uk> <20120516021828.GP22082@ZenIV.linux.org.uk> <1337807899.15138.31.camel@falcor> <20120530043443.GA3200@ZenIV.linux.org.uk> <20120530163605.GV11775@ZenIV.linux.org.uk> <1338406967.2257.24.camel@localhost> <20120530202427.GW11775@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 26 On Wed, May 30, 2012 at 01:28:09PM -0700, Linus Torvalds wrote: > On Wed, May 30, 2012 at 1:24 PM, Al Viro wrote: > > On Wed, May 30, 2012 at 03:42:47PM -0400, Eric Paris wrote: > >> security_file_mmap() would pretty much only be used in do_mmap_pgoff() > >> (or validate_mmap_request) > > > > Callers, actually - the whole point is to lift it out of under ->mmap_sem. > > The tricky part is reqprot vs. prot mess. > > See how I solved reqprot vs prot in my suggested original patch. You > have it somewhere in your inbox, I know, because you called me out on > the fact that my original email forgot to attach it ;) > > It actually cleaned things up, and made the calling conventions > simpler. Just always pass in "reqprot", and have the security layer do > the trivial "calculate final prot". If only it would be trivial ;-/ Take a look at !MMU case (or at the description in the posting upthread if you want to avoid seeing your breakfast one more time - the code in validate_mmap_request() is really ugly). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/