Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757006Ab2E3Vrx (ORCPT ); Wed, 30 May 2012 17:47:53 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:48009 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812Ab2E3Vrv (ORCPT ); Wed, 30 May 2012 17:47:51 -0400 Date: Wed, 30 May 2012 23:47:32 +0200 (CEST) From: Eldad Zack X-X-Sender: eldad@debianer To: David Miller cc: kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] 8021q/vlan: process NETDEV_GOING_DOWN In-Reply-To: <20120530.162751.80640634568619332.davem@davemloft.net> Message-ID: References: <1338330635-27259-1-git-send-email-eldad@fogrefinery.com> <20120529.204040.644013889059321702.davem@davemloft.net> <20120530.162751.80640634568619332.davem@davemloft.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 25 On Wed, 30 May 2012, David Miller wrote: > From: Eldad Zack > Date: Wed, 30 May 2012 21:11:02 +0200 (CEST) > > > In case a certain protocol needs to send a "dying gasp" packet, when you > > administrativly shutdown the port (which is also what happens when you > > restart the machine). > > No in tree users have this requirement, therefore your patch is > inappropriate. You are right in that, that no in tree users have this requirement (yet), but in the same time it doesn't harm any existing code. Don't you agree that it's the right order to do the notifications? And if so, isn't that enough, considering that there are no side effects and it's a tiny change? Eldad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/