Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755810Ab2EaAWk (ORCPT ); Wed, 30 May 2012 20:22:40 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:61507 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724Ab2EaAWi (ORCPT ); Wed, 30 May 2012 20:22:38 -0400 MIME-Version: 1.0 In-Reply-To: <4FC6B68C.2070703@jp.fujitsu.com> References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> From: KOSAKI Motohiro Date: Wed, 30 May 2012 20:22:16 -0400 Message-ID: Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg To: Kamezawa Hiroyuki Cc: David Rientjes , Gao feng , hannes@cmpxchg.org, mhocko@suse.cz, bsingharora@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, containers@lists.linux-foundation.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1943 Lines: 47 On Wed, May 30, 2012 at 8:08 PM, Kamezawa Hiroyuki wrote: > (2012/05/31 6:38), David Rientjes wrote: >> >> On Tue, 29 May 2012, Gao feng wrote: >> >>> cgroup and namespaces are used for creating containers but some of >>> information is not isolated/virtualized. This patch is for isolating >>> /proc/meminfo >>> information per container, which uses memory cgroup. By this, top,free >>> and other tools under container can work as expected(show container's >>> usage) without changes. >>> >>> This patch is a trial to show memcg's info in /proc/meminfo if 'current' >>> is under a memcg other than root. >>> >>> we show /proc/meminfo base on container's memory cgroup. >>> because there are lots of info can't be provide by memcg, and >>> the cmds such as top, free just use some entries of /proc/meminfo, >>> we replace those entries by memory cgroup. >>> >>> if container has no memcg, we will show host's /proc/meminfo >>> as before. >>> >>> there is no idea how to deal with Buffers,I just set it zero, >>> It's strange if Buffers bigger than MemTotal. >>> >>> Signed-off-by: Gao feng >> >> >> Nack, this type of thing was initially tried with cpusets when a thread >> was bound to a subset of nodes, i.e. only show the total amount of memory >> spanned by those nodes. >> > > Hmm. How about having memory.meminfo under memory cgroup directory and > use it with bind mount ? (container tools will be able to help it.) > Then, container applications(top,free,etc..) can read the values they wants. > If admins don't want it, they'll not use bind mount. +1. 50% users need namespace separation and others don't. We need a selectability. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/