Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757808Ab2EaB5v (ORCPT ); Wed, 30 May 2012 21:57:51 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:38840 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757723Ab2EaB5u (ORCPT ); Wed, 30 May 2012 21:57:50 -0400 Date: Wed, 30 May 2012 18:57:47 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Aneesh Kumar K.V" cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, mhocko@suse.cz, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Andrea Arcangeli Subject: Re: [PATCH -V7 05/14] hugetlb: avoid taking i_mmap_mutex in unmap_single_vma() for hugetlb In-Reply-To: <1338388739-22919-6-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Message-ID: References: <1338388739-22919-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1338388739-22919-6-git-send-email-aneesh.kumar@linux.vnet.ibm.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1328 Lines: 32 On Wed, 30 May 2012, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > i_mmap_mutex lock was added in unmap_single_vma by 502717f4e ("hugetlb: > fix linked list corruption in unmap_hugepage_range()") but we don't use > page->lru in unmap_hugepage_range any more. Also the lock was taken > higher up in the stack in some code path. That would result in deadlock. > > unmap_mapping_range (i_mmap_mutex) > -> unmap_mapping_range_tree > -> unmap_mapping_range_vma > -> zap_page_range_single > -> unmap_single_vma > -> unmap_hugepage_range (i_mmap_mutex) > You should be able to show this with lockdep? > For shared pagetable support for huge pages, since pagetable pages are ref > counted we don't need any lock during huge_pmd_unshare. We do take > i_mmap_mutex in huge_pmd_share while walking the vma_prio_tree in mapping. > (39dde65c9940c97f ("shared page table for hugetlb page")). > I think this should be folded into patch 4, the code you're removing here is just added in that function unnecessarily. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/