Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157Ab2EaGiM (ORCPT ); Thu, 31 May 2012 02:38:12 -0400 Received: from mga02.intel.com ([134.134.136.20]:21118 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059Ab2EaGiK (ORCPT ); Thu, 31 May 2012 02:38:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="146503915" From: Feng Tang To: Arnaldo Carvalho de Melo , David Ahern , Peter Zijlstra , Ingo Molnar , Andi Kleen , Robert Richter , linux-kernel@vger.kernel.org Cc: Feng Tang Subject: [PATCH v2 3/3] perf script/python: Pass thread/dso name and symbol info to event handler in python Date: Thu, 31 May 2012 14:34:32 +0800 Message-Id: <1338446072-24655-3-git-send-email-feng.tang@intel.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1338446072-24655-1-git-send-email-feng.tang@intel.com> References: <1338446072-24655-1-git-send-email-feng.tang@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3026 Lines: 83 Also as suggested by Arnaldo, pack all these parameters to a dictionary, which is more expandable for adding new parameters while keep the compatibility for old scripts. Signed-off-by: Feng Tang --- .../util/scripting-engines/trace-event-python.c | 31 +++++++++++++++---- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/scripting-engines/trace-event-python.c b/tools/perf/util/scripting-engines/trace-event-python.c index 97f4fad..92f1833 100644 --- a/tools/perf/util/scripting-engines/trace-event-python.c +++ b/tools/perf/util/scripting-engines/trace-event-python.c @@ -336,15 +336,23 @@ static void python_process_general_event(union perf_event *pevent __unused, struct machine *machine __unused, struct addr_location *al) { - PyObject *handler, *retval, *t; + PyObject *handler, *retval, *t, *dict; static char handler_name[64]; unsigned n = 0; - void *data = sample->raw_data; + struct thread *thread = al->thread; + /* + * Use the MAX_FIELDS to make the function expandable, though + * currently there is only one itme for the tuple. + */ t = PyTuple_New(MAX_FIELDS); if (!t) Py_FatalError("couldn't create Python tuple"); + dict = PyDict_New(); + if (!dict) + Py_FatalError("couldn't create Python dictionary"); + snprintf(handler_name, sizeof(handler_name), "%s", "process_event"); handler = PyDict_GetItemString(main_dict, handler_name); @@ -353,14 +361,22 @@ static void python_process_general_event(union perf_event *pevent __unused, goto exit; } - /* Pass 4 parameters: event_attr, perf_sample, raw data, thread name */ - PyTuple_SetItem(t, n++, PyString_FromStringAndSize( + PyDict_SetItemString(dict, "attr", PyString_FromStringAndSize( (const char *)&evsel->attr, sizeof(evsel->attr))); - PyTuple_SetItem(t, n++, PyString_FromStringAndSize( + PyDict_SetItemString(dict, "sample", PyString_FromStringAndSize( (const char *)sample, sizeof(*sample))); - PyTuple_SetItem(t, n++, PyString_FromStringAndSize( - data, sample->raw_size)); + PyDict_SetItemString(dict, "raw_buf", PyString_FromStringAndSize( + (const char *)sample->raw_data, sample->raw_size)); + PyDict_SetItemString(dict, "comm", + PyString_FromString(thread->comm)); + PyDict_SetItemString(dict, "dso", + PyString_FromString(al->map->dso->name)); + if (al->sym) { + PyDict_SetItemString(dict, "symbol", + PyString_FromString(al->sym->name)); + } + PyTuple_SetItem(t, n++, dict); if (_PyTuple_Resize(&t, n) == -1) Py_FatalError("error resizing Python tuple"); @@ -368,6 +384,7 @@ static void python_process_general_event(union perf_event *pevent __unused, if (retval == NULL) handler_call_die(handler_name); exit: + Py_DECREF(dict); Py_DECREF(t); } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/