Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757871Ab2EaHmn (ORCPT ); Thu, 31 May 2012 03:42:43 -0400 Received: from mail-qa0-f49.google.com ([209.85.216.49]:50848 "EHLO mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059Ab2EaHml (ORCPT ); Thu, 31 May 2012 03:42:41 -0400 Message-ID: <4FC720EE.3010307@gmail.com> Date: Thu, 31 May 2012 03:42:38 -0400 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: David Rientjes CC: KOSAKI Motohiro , Kamezawa Hiroyuki , Gao feng , hannes@cmpxchg.org, mhocko@suse.cz, bsingharora@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, containers@lists.linux-foundation.org Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> <4FC6BC3E.5010807@jp.fujitsu.com> <4FC6C111.2060108@jp.fujitsu.com> <4FC6D881.4090706@jp.fujitsu.com> <4FC70355.70805@jp.fujitsu.com> <4FC70E5E.1010003@gmail.com> <4FC711A5.4090003@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2069 Lines: 43 (5/31/12 3:35 AM), David Rientjes wrote: > On Thu, 31 May 2012, KOSAKI Motohiro wrote: > >>> As I said, LXC and namespace isolation is a tangent to the discussion of >>> faking the /proc/meminfo for the memcg context of a thread. >> >> Because of, /proc/meminfo affect a lot of libraries behavior. So, it's not only >> application issue. If you can't rewrite _all_ of userland assets, fake meminfo >> can't be escaped. Again see alternative container implementation. >> > > It's a tangent because it isn't a complete psuedo /proc/meminfo for all > threads attached to a memcg regardless of any namespace isolation; the LXC > solution has existed for a couple of years by its procfs patchset that > overlaps procfs with fuse and can suppress or modify any output in the > context of a memory controller using things like > memory.{limit,usage}_in_bytes. I'm sure all other fields could be > modified if outputted in some structured way via memcg; it looks like > memory.stat would need to be extended to provide that. If that's mounted > prior to executing the application, then your isolation is achieved and > all libraries should see the new output that you've defined in LXC. > > However, this seems like a seperate topic than the patch at hand which > does this directly to /proc/meminfo based on a thread's memcg context, > that's the part that I'm nacking. Then, I NAKed current patch too. Yeah, current one is ugly. It assume _all_ user need namespace isolation and it clearly is not. > I'd recommend to Gao to expose this > information via memory.stat and then use fuse and the procfs lxc support > as your way of contextualizing the resources. It's one of a option. But, I seriously doubt fuse can make simpler than kamezawa-san's idea. But yeah, I might NACK kamezawa-san's one if he will post ugly patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/