Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753699Ab2EaJFX (ORCPT ); Thu, 31 May 2012 05:05:23 -0400 Received: from smtp2.it.da.ut.ee ([193.40.5.67]:48996 "EHLO smtp2.it.da.ut.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753130Ab2EaJFV (ORCPT ); Thu, 31 May 2012 05:05:21 -0400 Date: Thu, 31 May 2012 12:05:15 +0300 (EEST) From: mroos@linux.ee To: Dan Williams cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, JBottomley@parallels.com Subject: Re: [PATCH v2 0/4] fix / cleanup async scsi scanning In-Reply-To: <20120530182016.23574.11056.stgit@dwillia2-linux.jf.intel.com> Message-ID: References: <20120530182016.23574.11056.stgit@dwillia2-linux.jf.intel.com> User-Agent: Alpine 1.00 (SOC 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 32 > Commit a7a20d10 "[SCSI] sd: limit the scope of the async probe domain" > introduces a boot regression by moving sd probe work off of the global > async queue. Using a local async domain hides the probe work from being > synchronized by wait_for_device_probe()->async_synchronize_full(). > > Fix this by teaching async_synchronize_full() to flush all async work > regardless of domain, and take the opportunity to convert scsi scanning > to async_schedule(). This enables wait_for_device_probe() to flush scsi > scanning work. > > Changes since v1: http://marc.info/?l=linux-scsi&m=133793153025832&w=2 > > 1/ Tested to fix the boot hang that Meelis reported with v1. Reworked > async_synchronize_full() to walk through all the active domains, > otherwise we spin on !list_empty(async_domains) and prevent the async > context from running. > > 2/ Added the ability for domains to opt-out of global syncing as > requested by Arjan, but also needed for domains that don't want to worry > about list corruption when the domain goes out of scope (stack-allocated > domains). Tested successfully on my Netra X1 where the original problem happened, on top of 3.4.0-08215-g1e2aec8. Thank you! -- Meelis Roos (mroos@linux.ee) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/