Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756983Ab2EaKMs (ORCPT ); Thu, 31 May 2012 06:12:48 -0400 Received: from static.78-46-68-141.clients.your-server.de ([78.46.68.141]:56545 "HELO eristoteles.iwoars.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with SMTP id S1752124Ab2EaKMq (ORCPT ); Thu, 31 May 2012 06:12:46 -0400 Date: Thu, 31 May 2012 12:12:42 +0200 (CEST) From: Joel Reardon X-X-Sender: joel@eristoteles.iwoars.net To: Artem Bityutskiy cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] UBIFS: compute KSA size and store in superblock In-Reply-To: <1338391121.2536.94.camel@sauron.fi.intel.com> Message-ID: References: <1337952271.30969.37.camel@sauron.fi.intel.com> <1338391121.2536.94.camel@sauron.fi.intel.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 43 > You need to validate that: > > 1. if use_ubifsec is true, then ksa_lebs is not zero. > 2. ksa_lebs is sane - not too small, not too large. > Will add an assert and a dbg check function. > > diff --git a/fs/ubifs/ubifs-media.h b/fs/ubifs/ubifs-media.h > > index 90f348c..1dda25d 100644 > > --- a/fs/ubifs/ubifs-media.h > > +++ b/fs/ubifs/ubifs-media.h > > @@ -618,10 +618,13 @@ struct ubifs_pad_node { > > * @rp_uid: reserve pool UID > > * @rp_gid: reserve pool GID > > * @rp_size: size of the reserved pool in bytes > > - * @padding2: reserved for future, zeroes > > Do not remove this comment. > I only moved it, new fields were added to the struct and it was not longer in the correct place in the comment. > > * @time_gran: time granularity in nanoseconds > > * @uuid: UUID generated when the file system image was created > > * @ro_compat_version: UBIFS R/O compatibility version > > + * @crypto_lebs: number of LEBS being used to store keys > > + * @use_ubifsec: the LSB signifies whether the file system should use secure > > + * deletion > > + * @padding2: reserved for future, zeroes > > */ Cheers, Joel Reardon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/