Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685Ab2EaKpm (ORCPT ); Thu, 31 May 2012 06:45:42 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:54099 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751304Ab2EaKpl (ORCPT ); Thu, 31 May 2012 06:45:41 -0400 Date: Thu, 31 May 2012 11:45:38 +0100 From: Mark Brown To: Tomoya MORINAGA Cc: Vinod Koul , alsa-devel@alsa-project.org, lars@metafoo.de, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood Subject: Re: [alsa-devel] [PATCH v5] sound/soc/lapis: add platform driver for ML7213 Message-ID: <20120531104538.GA2666@opensource.wolfsonmicro.com> References: <20120523093857.GC4085@opensource.wolfsonmicro.com> <20120524100742.GH5361@opensource.wolfsonmicro.com> <1337941231.1580.19.camel@vkoul-udesk3> <20120527221956.GB25019@opensource.wolfsonmicro.com> <20120530121449.GI9947@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: X-Cookie: You are fairminded, just and loving. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2464 Lines: 62 --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 31, 2012 at 02:38:30PM +0900, Tomoya MORINAGA wrote: > On Wed, May 30, 2012 at 9:14 PM, Mark Brown > > Please re-read what I wrote. > Let me clarify. > Do you say native DMA driver API like dmaengine_prep_slave_sg(), > dmaengine_submit() shouldn't be used from ASoC driver, right ? Your driver should be written in terms of the ASoC DMA framework. > > No, all current mainline drivers using the library use cyclic DMA. > I can't see any driver uses cyclic DMA. (I saw linux-next's tree from > kernel.org.) > Where is your saying "current mainline" ? Linus' tree, or mine. Have you even looked at the soc-dmaengine-pcm code? It uncondtionally requests a cyclic channel. > However I think it seems difficult for supporting all devices. > Because hardware dependency control code can't be added. > For example, for ML7213, needs interrupt control both before/after DMA transfer. > However, in case of using soc-dmaengine, the control can't be done. > Because the processing is in soc-dmaengine. Please be more specific. What are the concrete problems that you see? Why is it not possible to address them within the framework? --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJPx0vLAAoJEBus8iNuMP3daOUP/jeBkne9p6xpOBBMU/sT93mG 3sGyS/mgJewK6VMx5h4t8D6eXNhWxxu6wtdVGvLoK50iZv7FsMkFdM3WU+gtTuX5 4cFQ5XIAcUCkPUCpaI7261tAEJNT5UGKxx/8t6pxH6jKwDKde7KGmR4fGKLESbES 5jyJgOyn29ZVXzUJ4gKOw7kKtCHSylR0XzhVZDdvVVi/pNcUhdbLOqKy+KxFiJ3O v86iftLLta2yIf9HVJnbntprWEtFjV5xT5WfYsV06Nkw3lrn9+aXYo9/XKIXklPh 6wNEnQ2GG9iNOazPbTuHXa775YsFoDN9xy8AC6sGc+AumpZgSYuzTmtFTIEvd2hU 9yxaoMAsiLktcbwhSIl9PEEibu68INjPsQF7dHG6kW9ySgG3zSKeikfDI6FUFrA8 pcwSt4UgGdwlG1krmNcYxVrfs9nD1gc2h+LiMxoIhv26LxjIGBDKpXTLVXVwOHVL NOe13aZsWjST0mB8r/CrgavJvdd/rIo7yM7rcOP/u7vnt+baYLIZWRlh2mnd6Kj3 MgIzfNXMOlRkYir7MO+27d4MOp6qHzGwxGZIEJqdvt1DGR2mbfAV3vCHXleyrNcK /YvtyeU+yqvX/uhYGscHc2nHUSxQ7egj2SPPvsdI03GXvpbD9Z0saFzarYFNDsAZ GVByp+6fOfXy9uUR5J2Z =jXl1 -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/