Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757272Ab2EaLth (ORCPT ); Thu, 31 May 2012 07:49:37 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:58058 "EHLO e23smtp07.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757084Ab2EaLtg (ORCPT ); Thu, 31 May 2012 07:49:36 -0400 From: Srikar Dronamraju To: Peter Zijlstra , Ingo Molnar Cc: Linus Torvalds , Ananth N Mavinakayanahalli , LKML , Oleg Nesterov , Steven Rostedt , Arnaldo Carvalho de Melo , Masami Hiramatsu , Anton Arapov Date: Thu, 31 May 2012 17:16:43 +0530 Message-Id: <20120531114643.23691.38666.sendpatchset@srdronam.in.ibm.com> In-Reply-To: <20120531114630.23691.33166.sendpatchset@srdronam.in.ibm.com> References: <20120531114630.23691.33166.sendpatchset@srdronam.in.ibm.com> Subject: [PATCH 2/3] perf/uprobes: Remove unnecessary check before strlist__delete x-cbid: 12053101-0260-0000-0000-000001450B4D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 43 From: Srikar Dronamraju Since strlist__delete() itself checks, the additional check before calling strlist__delete() is redundant. No Functional change. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Srikar Dronamraju --- tools/perf/util/probe-event.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 59dccc9..0dda25d 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -2164,16 +2164,12 @@ int del_perf_probe_events(struct strlist *dellist) error: if (kfd >= 0) { - if (namelist) - strlist__delete(namelist); - + strlist__delete(namelist); close(kfd); } if (ufd >= 0) { - if (unamelist) - strlist__delete(unamelist); - + strlist__delete(unamelist); close(ufd); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/