Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757338Ab2EaL66 (ORCPT ); Thu, 31 May 2012 07:58:58 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49643 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756626Ab2EaL65 convert rfc822-to-8bit (ORCPT ); Thu, 31 May 2012 07:58:57 -0400 Message-ID: <1338465518.28384.55.camel@twins> Subject: Re: [PATCH 1/3] uprobes/core: Remove redundant lock_page/unlock_page From: Peter Zijlstra To: Srikar Dronamraju Cc: Ingo Molnar , Linus Torvalds , Ananth N Mavinakayanahalli , LKML , Oleg Nesterov , Steven Rostedt , Arnaldo Carvalho de Melo , Masami Hiramatsu , Anton Arapov Date: Thu, 31 May 2012 13:58:38 +0200 In-Reply-To: <20120531114630.23691.33166.sendpatchset@srdronam.in.ibm.com> References: <20120531114630.23691.33166.sendpatchset@srdronam.in.ibm.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 493 Lines: 12 On Thu, 2012-05-31 at 17:16 +0530, Srikar Dronamraju wrote: > From: Srikar Dronamraju > > No need to lock the page when copying the opcode in read_opcode(). It would be good if the changelog said _why_ this is so :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/