Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
In-Reply-To: <87r4u6w58c.fsf@rustcorp.com.au>
References: <87r4u6w58c.fsf@rustcorp.com.au> <8762blyedn.fsf@rustcorp.com.au> <87obpfxdpr.fsf@rustcorp.com.au> <20120522230218.24007.3556.stgit@warthog.procyon.org.uk> <7474.1337782847@redhat.com> <5107.1337868051@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: dhowells@redhat.com, kyle@mcmartin.ca, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org, keyrings@linux-nfs.org
Subject: Re: [PATCH 00/23] Crypto keys and module signing
Date: Thu, 31 May 2012 15:11:02 +0100
Message-ID: <17249.1338473462@redhat.com>
From: David Howells <dhowells@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1141
Lines: 28

Rusty Russell <rusty@rustcorp.com.au> wrote:

> > That then adds 5 bytes to the magic string.  Is that really so bad?
> 
> Yes, because it's unnecessary.

I'm sorry Rusty, but this argument is disingenuous.

Yes, a length field in the file is unnecessary - BUT SO TOO is scanning!  By
this argument, your idea is really so bad too.  It's all about the trade off
one chooses to make.  I do not accept your chosen trade off[*] as being the
best one.

David

[*] And, yes, it *is* a trade off: you are trading CPU time and permanently
    resident kernel code space in order to save a tiny amount of disk
    space[**].

[**] Assuming 512 byte blocks and a 5 byte size field, probably fewer than 1%
     of modules will expand sufficiently to consume an extra block.  Further,
     making it a 2-byte binary field would make it even less intrusive, both
     in the file and in the module verifier.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/