Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753532Ab2EaOWJ (ORCPT ); Thu, 31 May 2012 10:22:09 -0400 Received: from s15943758.onlinehome-server.info ([217.160.130.188]:42801 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145Ab2EaOWH (ORCPT ); Thu, 31 May 2012 10:22:07 -0400 Date: Thu, 31 May 2012 16:22:29 +0200 From: Borislav Petkov To: Mauro Carvalho Chehab Cc: "Luck, Tony" , Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson , Steven Rostedt , Frederic Weisbecker , Ingo Molnar Subject: Re: [PATCH] RAS: Add a tracepoint for reporting memory controller events Message-ID: <20120531142229.GF14515@aftab.osrc.amd.com> References: <4FBE7755.2080301@redhat.com> <20120529115851.GB29157@aftab.osrc.amd.com> <4FC4D6E2.9060501@redhat.com> <20120529145245.GG29157@aftab.osrc.amd.com> <4FC4E9EB.5030801@redhat.com> <3908561D78D1C84285E8C5FCA982C28F192F6672@ORSMSX104.amr.corp.intel.com> <20120531100005.GC14074@aftab.osrc.amd.com> <4FC748F5.9070709@redhat.com> <20120531121741.GB14515@aftab.osrc.amd.com> <4FC7788C.1070405@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FC7788C.1070405@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1332 Lines: 32 On Thu, May 31, 2012 at 10:56:28AM -0300, Mauro Carvalho Chehab wrote: > Em 31-05-2012 09:17, Borislav Petkov escreveu: > > On Thu, May 31, 2012 at 07:33:25AM -0300, Mauro Carvalho Chehab wrote: > >> Huh? Tony said that some errors report at 4K granularity while, others > >> are at cache line size. > > > > Cacheline size is from MCE. This tracepoint is for memory controller > > errors where granularity should be pretty stable. > > Both sb_edac and i7core_edac get errors via MCE. They're currently providing > a fake granularity, but I'm planning to add proper grain support on them, > by retrieving such information from the MCE registers. Those are only 2 drivers and not _all_ edac drivers. For the remaining ones grain is a pretty stable, seldomly changing value. Which means it should be part of const char driver_detail only on those two drivers and not a driver-global field in the tracepoint. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/