Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933239Ab2EaToq (ORCPT ); Thu, 31 May 2012 15:44:46 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:44976 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933217Ab2EaTop (ORCPT ); Thu, 31 May 2012 15:44:45 -0400 Message-ID: <1338493483.7229.2.camel@joe2Laptop> Subject: Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for & From: Joe Perches To: balbi@ti.com Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 31 May 2012 12:44:43 -0700 In-Reply-To: <20120531072541.GC5377@arwen.pp.htv.fi> References: <2530fb0cbede64dad718d41012156043d1ca424e.1338408931.git.joe@perches.com> <20120531072541.GC5377@arwen.pp.htv.fi> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 17 On Thu, 2012-05-31 at 10:25 +0300, Felipe Balbi wrote: > On Wed, May 30, 2012 at 01:25:57PM -0700, Joe Perches wrote: > > Using | with a constant is always true. > > Likely this should have be &. > > Signed-off-by: Joe Perches > this looks good to me. Do you want me to carry it on my tree ? > If you want to carry it out as a fix: > Acked-by: Felipe Balbi I presume that question is for Greg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/