Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964824Ab2EaUJW (ORCPT ); Thu, 31 May 2012 16:09:22 -0400 Received: from mail-qa0-f49.google.com ([209.85.216.49]:39655 "EHLO mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933243Ab2EaUJU (ORCPT ); Thu, 31 May 2012 16:09:20 -0400 Message-ID: <4FC7CFEB.5040009@gmail.com> Date: Thu, 31 May 2012 16:09:15 -0400 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Nathan Zimmer CC: hughd@google.com, npiggin@gmail.com, cl@linux.com, lee.schermerhorn@hp.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, riel@redhat.com, kosaki.motohiro@gmail.com Subject: Re: [PATCH v2] tmpfs not interleaving properly References: <20120531143916.GA16162@gulag1.americas.sgi.com> In-Reply-To: <20120531143916.GA16162@gulag1.americas.sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2610 Lines: 65 (5/31/12 10:39 AM), Nathan Zimmer wrote: > When tmpfs has the memory policy interleaved it always starts allocating at each > file at node 0. When there are many small files the lower nodes fill up > disproportionately. > This patch attempts to spread out node usage by starting files at nodes other > then 0. I disturbed the addr parameter since alloc_pages_vma will only use it > when the policy is MPOL_INTERLEAVE. Random was picked over using another > variable which would require some sort of contention management. > > Cc: Christoph Lameter > Cc: Nick Piggin > Cc: Hugh Dickins > Cc: Lee Schermerhorn > Acked-by: Rik van Riel > Cc: stable@vger.kernel.org > Signed-off-by: Nathan T Zimmer > --- > include/linux/shmem_fs.h | 1 + > mm/shmem.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index bef2cf0..cfe8a34 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -17,6 +17,7 @@ struct shmem_inode_info { > char *symlink; /* unswappable short symlink */ > }; > struct shared_policy policy; /* NUMA memory alloc policy */ > + unsigned long node_offset; /* bias for interleaved nodes */ > struct list_head swaplist; /* chain of maybes on swap */ > struct list_head xattr_list; /* list of shmem_xattr */ > struct inode vfs_inode; > diff --git a/mm/shmem.c b/mm/shmem.c > index d576b84..69a47fb 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -929,7 +929,7 @@ static struct page *shmem_alloc_page(gfp_t gfp, > /* > * alloc_page_vma() will drop the shared policy reference > */ > - return alloc_page_vma(gfp,&pvma, 0); > + return alloc_page_vma(gfp,&pvma, info->node_offset<< PAGE_SHIFT ); 3rd argument of alloc_page_vma() is an address. This is type error. > } > #else /* !CONFIG_NUMA */ > #ifdef CONFIG_TMPFS > @@ -1357,6 +1357,7 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode > inode->i_fop =&shmem_file_operations; > mpol_shared_policy_init(&info->policy, > shmem_get_sbmpol(sbinfo)); > + info->node_offset = node_random(&node_online_map); > break; > case S_IFDIR: > inc_nlink(inode); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/