Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758824Ab2FACyy (ORCPT ); Thu, 31 May 2012 22:54:54 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:37260 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758737Ab2FACyw (ORCPT ); Thu, 31 May 2012 22:54:52 -0400 Message-ID: <1338519291.9151.7.camel@joe2Laptop> Subject: Re: [PATCH] lib/decompress_unxz.c: removing all memory helper functions From: Joe Perches To: Thavatchai Makphaibulcboke Cc: Jean-Christophe PLAGNIOL-VILLARD , "lethal@linux-sh.org" , "hpa@zytor.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "x86@kernel.org" , "kaloz@openwrt.org" , "matt.fleming@intel.com" , "lasse.collin@tukaani.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux@arm.linux.org.uk" , "schwidefsky@de.ibm.com" , "heiko.carstens@de.ibm.com" , "linux390@de.ibm.com" Date: Thu, 31 May 2012 19:54:51 -0700 In-Reply-To: <4FC82D89.1040108@hp.com> References: <1337875436-27640-1-git-send-email-tmac@hp.com> <20120528070336.GM3377@game.jcrosoft.org> <4FC82D89.1040108@hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 22 On Thu, 2012-05-31 at 20:48 -0600, Thavatchai Makphaibulcboke wrote: > On 05/28/2012 01:03 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > can we do not duplicate those functions? > > Thanks J for the comment. Unfortunately, there is no easy way to share > files among different architectures' preboot environment. We have the > choices either to have each architecture define its own copies or the > decompressor defines them. I believe the former is preferable. As > Lasse also pointed out, this way any specific architecture could provide > an architectural dependent optimized version, if it chooses to. Maybe provide __weak default functions that can be overridden by any arch that could or wants to improve on the defaults. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/