Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932789Ab2FAMW5 (ORCPT ); Fri, 1 Jun 2012 08:22:57 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:59896 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759526Ab2FAMWz (ORCPT ); Fri, 1 Jun 2012 08:22:55 -0400 Date: Fri, 1 Jun 2012 05:21:18 -0700 From: Anton Vorontsov To: Pekka Enberg Cc: KOSAKI Motohiro , Minchan Kim , Leonid Moiseichuk , John Stultz , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Subject: [PATCH 0/5] Some vmevent fixes... Message-ID: <20120601122118.GA6128@lizard> References: <20120504073810.GA25175@lizard> <20120507121527.GA19526@lizard> <4FA82056.2070706@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 49 On Tue, May 08, 2012 at 10:36:31AM +0300, Pekka Enberg wrote: [...] > > 2) VMEVENT_ATTR_STATE_ONE_SHOT is misleading name. That is effect as > > edge trigger shot. not only once. > > Would VMEVENT_ATTR_STATE_EDGE_TRIGGER be a better name? [...] > > 4) Currently, vmstat have per-cpu batch and vmstat updating makes 3 > > second delay at maximum. > >  This is fine for usual case because almost userland watcher only > > read /proc/vmstat per second. > >  But, for vmevent_fd() case, 3 seconds may be unacceptable delay. At > > worst, 128 batch x 4096 > >  x 4k pagesize = 2G bytes inaccurate is there. > > That's pretty awful. Anton, Leonid, comments? [...] > > 5) __VMEVENT_ATTR_STATE_VALUE_WAS_LT should be removed from userland > > exporting files. > >  When exporing kenrel internal, always silly gus used them and made unhappy. > > Agreed. Anton, care to cook up a patch to do that? KOSAKI-San, Pekka, Much thanks for your reviews! These three issues should be fixed by the following patches. One mm/ change is needed outside of vmevent... And I'm looking into other issues you pointed out... Thanks! --- include/linux/vmevent.h | 10 +++---- include/linux/vmstat.h | 2 ++ mm/vmevent.c | 66 +++++++++++++++++++++++++++++------------------ mm/vmstat.c | 22 +++++++++++++++- 4 files changed, 68 insertions(+), 32 deletions(-) -- Anton Vorontsov Email: cbouatmailru@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/