Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965545Ab2FAQvS (ORCPT ); Fri, 1 Jun 2012 12:51:18 -0400 Received: from smtp.snhosting.dk ([87.238.248.203]:42796 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965469Ab2FAQvQ (ORCPT ); Fri, 1 Jun 2012 12:51:16 -0400 Date: Fri, 1 Jun 2012 18:51:13 +0200 From: Sam Ravnborg To: "Srivatsa S. Bhat" Cc: tglx@linutronix.de, peterz@infradead.org, paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org, yong.zhang0@gmail.com, akpm@linux-foundation.org, vatsa@linux.vnet.ibm.com, rjw@sisk.pl, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, nikunj@linux.vnet.ibm.com, Suresh Siddha , Venkatesh Pallipadi Subject: Re: [PATCH 01/27] smpboot: Provide a generic method to boot secondary processors Message-ID: <20120601165113.GA18870@merkur.ravnborg.org> References: <20120601090952.31979.24799.stgit@srivatsabhat.in.ibm.com> <20120601091008.31979.93586.stgit@srivatsabhat.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120601091008.31979.93586.stgit@srivatsabhat.in.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 26 > +/* Implement the following functions in your architecture, as appropriate. */ > + > +/** > + * __cpu_pre_starting() > + * > + * Implement whatever you need to do before the CPU_STARTING notifiers are > + * invoked. Note that the CPU_STARTING callbacks run *on* the cpu that is > + * coming up. So that cpu better be prepared! IOW, implement all the early > + * boot/init code for the cpu here. And do NOT enable interrupts. > + */ > +#ifndef __cpu_pre_starting > +void __weak __cpu_pre_starting(void *arg) {} > +#endif __What __is __the __purpose __of __all __these __underscaores __used __as __function __prefix? __It __does __not __help __readability. Does the nicely worded comment follow kerneldoc style? I think not as the parameter is not described. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/