Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965714Ab2FASyb (ORCPT ); Fri, 1 Jun 2012 14:54:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50592 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932805Ab2FASya (ORCPT ); Fri, 1 Jun 2012 14:54:30 -0400 Date: Fri, 1 Jun 2012 20:52:37 +0200 From: Oleg Nesterov To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Linus Torvalds , Ananth N Mavinakayanahalli , LKML , Steven Rostedt , Arnaldo Carvalho de Melo , Masami Hiramatsu , Anton Arapov Subject: Re: [RESEND PATCH 1/3] uprobes: Remove redundant lock_page/unlock_page Message-ID: <20120601185237.GC31771@redhat.com> References: <20120531114630.23691.33166.sendpatchset@srdronam.in.ibm.com> <1338465518.28384.55.camel@twins> <20120531150756.GC24279@linux.vnet.ibm.com> <1338483372.28384.65.camel@twins> <20120601091950.GF24279@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120601091950.GF24279@linux.vnet.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 22 On 06/01, Srikar Dronamraju wrote: > > @@ -315,12 +315,10 @@ static int read_opcode(struct mm_struct *mm, unsigned long vaddr, uprobe_opcode_ > if (ret <= 0) > return ret; > > - lock_page(page); > vaddr_new = kmap_atomic(page); > vaddr &= ~PAGE_MASK; > memcpy(opcode, vaddr_new + vaddr, UPROBE_SWBP_INSN_SIZE); > kunmap_atomic(vaddr_new); > - unlock_page(page); Great, this lock_page() was really confusing. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/