Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757217Ab2FCImf (ORCPT ); Sun, 3 Jun 2012 04:42:35 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:44838 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812Ab2FCImG (ORCPT ); Sun, 3 Jun 2012 04:42:06 -0400 Date: Sun, 3 Jun 2012 16:41:46 +0800 From: Yong Zhang To: "Srivatsa S. Bhat" Cc: tglx@linutronix.de, peterz@infradead.org, paulmck@linux.vnet.ibm.com, rusty@rustcorp.com.au, mingo@kernel.org, akpm@linux-foundation.org, vatsa@linux.vnet.ibm.com, rjw@sisk.pl, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, nikunj@linux.vnet.ibm.com, Mikael Starvik , Jesper Nilsson , Eric Dumazet , Mike Frysinger , linux-cris-kernel@axis.com Subject: Re: [PATCH 23/27] cris, smpboot: Use generic SMP booting infrastructure Message-ID: <20120603084145.GC16829@zhy> Reply-To: Yong Zhang References: <20120601090952.31979.24799.stgit@srivatsabhat.in.ibm.com> <20120601091534.31979.34403.stgit@srivatsabhat.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20120601091534.31979.34403.stgit@srivatsabhat.in.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2218 Lines: 73 On Fri, Jun 01, 2012 at 02:45:40PM +0530, Srivatsa S. Bhat wrote: > Convert cris to use the generic framework to boot secondary CPUs. > > Cc: Mikael Starvik > Cc: Jesper Nilsson > Cc: Thomas Gleixner > Cc: Andrew Morton > Cc: Eric Dumazet > Cc: Mike Frysinger > Cc: linux-cris-kernel@axis.com > Signed-off-by: Srivatsa S. Bhat > --- > > arch/cris/arch-v32/kernel/smp.c | 14 ++++++-------- > 1 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/arch/cris/arch-v32/kernel/smp.c b/arch/cris/arch-v32/kernel/smp.c > index ebe2cb3..357114a 100644 > --- a/arch/cris/arch-v32/kernel/smp.c > +++ b/arch/cris/arch-v32/kernel/smp.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > > #define IPI_SCHEDULE 1 > #define IPI_CALL 2 > @@ -145,8 +146,11 @@ smp_boot_one_cpu(int cpuid, struct task_struct idle) > * specific stuff such as the local timer and the MMU. */ > void __init smp_callin(void) > { > - extern void cpu_idle(void); > + smpboot_start_secondary(NULL); > +} > > +void __cpuinit __cpu_pre_starting(void *unused) > +{ > int cpu = cpu_now_booting; > reg_intr_vect_rw_mask vect_mask = {0}; > > @@ -161,16 +165,10 @@ void __init smp_callin(void) > /* Setup local timer. */ > cris_timer_init(); > > - /* Enable IRQ and idle */ > + /* Enable IRQ */ I don't know cris; is the comments right? > REG_WR(intr_vect, irq_regs[cpu], rw_mask, vect_mask); > crisv32_unmask_irq(IPI_INTR_VECT); > crisv32_unmask_irq(TIMER0_INTR_VECT); > - preempt_disable(); > - notify_cpu_starting(cpu); > - local_irq_enable(); > - > - set_cpu_online(cpu, true); > - cpu_idle(); Before your patch, the comments seems end here. Thanks, Yong > } > > /* Stop execution on this CPU.*/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/