Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754172Ab2FCSXw (ORCPT ); Sun, 3 Jun 2012 14:23:52 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:40777 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754084Ab2FCSXv (ORCPT ); Sun, 3 Jun 2012 14:23:51 -0400 MIME-Version: 1.0 In-Reply-To: <20120603181548.GA306@redhat.com> References: <20120530163317.GA13189@redhat.com> <20120531005739.GA4532@redhat.com> <20120601023107.GA19445@redhat.com> <20120601161205.GA1918@redhat.com> <20120601171606.GA3794@redhat.com> <20120603181548.GA306@redhat.com> From: Linus Torvalds Date: Sun, 3 Jun 2012 11:23:29 -0700 X-Google-Sender-Auth: nt_fNlnp8FLv9cZ8UfCt9GDQupA Message-ID: Subject: Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170() To: Dave Jones , Hugh Dickins , Linus Torvalds , Bartlomiej Zolnierkiewicz , Kyungmin Park , Marek Szyprowski , Mel Gorman , Minchan Kim , Rik van Riel , Andrew Morton , Cong Wang , Markus Trippelsdorf , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 18 On Sun, Jun 3, 2012 at 11:15 AM, Dave Jones wrote: > > Things aren't happy with that patch at all. Yeah, at this point I think we need to just revert the compaction changes. Guys, what's the minimal set of commits to revert? That clearly buggy "rescue_unmovable_pageblock()" function was introduced by commit 5ceb9ce6fe94, but is that actually involved with the particular bug? That commit seems to revert cleanly still, but is that sufficient or does it even matter? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/