Subject: Re: [GIT PULL] x86/efi changes for v3.5
From: Matt Fleming <matt.fleming@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Henrik Rydberg <rydberg@euromail.se>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel@vger.kernel.org,
        Jordan Justen <jordan.l.justen@intel.com>,
        Matthew Garrett <mjg@redhat.com>
In-Reply-To: <4FCAD63D.7070604@zytor.com>
References: <20120523075433.GA12526@gmail.com>
	 <20120602183827.GA4020@polaris.bitmath.org>  <4FCAD63D.7070604@zytor.com>
Content-Type: text/plain; charset="UTF-8"
Organization: Intel Corporation (UK) Ltd. - Registered No. 1134945 - Pipers
 Way, Swindon SN3 1RJ
Date: Sun, 03 Jun 2012 21:40:27 +0100
Message-ID: <1338756027.4584.3.camel@mfleming-mobl1.ger.corp.intel.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1302
Lines: 36

On Sat, 2012-06-02 at 20:13 -0700, H. Peter Anvin wrote:
> On 06/02/2012 11:38 AM, Henrik Rydberg wrote:
> > Hi Ingo, Hans Peter, Matt, Jordan,
> > 
> >> This patchset makes changes to the bzImage EFI header, so that 
> >> it can be signed with a secure boot signature tool. It should 
> >> not affect anyone who is not using the EFI self-boot feature in 
> >> any way.
> > 
> > Commit 2e064b1 (Fix issue of overlapping .reloc section for EFI_STUB)
> > breaks EFI boot on my MacBookAir3,1. The efi firmware no longer
> > recognizes the bzImage and falls back to BIOS emulation boot.
> > 
> > Reverting 2e064b1 works for me, but I am happy to test other options
> > as well.
> > 
> 
> Matt, Jordan,
> 
> Could you look into this please?

Yeah, there's a bug report for this here,

	https://bugzilla.kernel.org/show_bug.cgi?id=43309

I suspect that older firmware doesn't handle a zero .reloc section
properly. So, unfortunately we will have to leave the .reloc section
with a dummy reloc, rather than having one with no entries.

I'll put a patch together.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/