Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755023Ab2FCWaQ (ORCPT ); Sun, 3 Jun 2012 18:30:16 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:52993 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754920Ab2FCWaO (ORCPT ); Sun, 3 Jun 2012 18:30:14 -0400 Date: Sun, 3 Jun 2012 15:29:46 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Linus Torvalds cc: Dave Jones , Bartlomiej Zolnierkiewicz , Kyungmin Park , Marek Szyprowski , Mel Gorman , Minchan Kim , Rik van Riel , Andrew Morton , Cong Wang , Markus Trippelsdorf , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170() In-Reply-To: Message-ID: References: <20120601023107.GA19445@redhat.com> <20120601161205.GA1918@redhat.com> <20120601171606.GA3794@redhat.com> <20120603181548.GA306@redhat.com> <20120603183139.GA1061@redhat.com> <20120603205332.GA5412@redhat.com> User-Agent: Alpine 2.00 (LSU 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1746 Lines: 37 On Sun, 3 Jun 2012, Linus Torvalds wrote: > On Sun, Jun 3, 2012 at 1:53 PM, Dave Jones wrote: > > > > running just over two hours with that commit reverted with no obvious ill effects so far. > > And how quickly have you usually seen the problems? Would you have > considered two ours "good" in your bisection thing? > > Also, just to check: Hugh sent out a patch called "mm: fix warning in > __set_page_dirty_nobuffers". Is that applied in your tree too, or did > the __set_page_dirty_nobuffers() warning go away with just the revert? That patch is good for fixing the __set_page_dirty_nobuffers() warning, but it has no relevance to the list corruption Dave was also reporting, nor vice versa. The common factor there is just Dave. And no disaster that the warning fix missed -rc1: it's only a WARN_ON_ONCE, and nothing was wrong beyond the warning itself, just noise. It's true that Dave's original bisection raised the doubt whether that warning is coming from somewhere else too; but best guess at this point is that something got mixed up, and we should only worry about that if we see the warning again once the known fix is in. Hugh > > I'm just trying to figure out exactly what you are testing. When you > said "test with that (and Hugh's last patch) backed out", the "and > Hugh's last patch" part was a bit ambiguous. Do you mean the trial > patch in this thread (backed out) or do you mean "*with* Hugh's patch > for the __set_page_dirty_nobuffers() warning". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/