Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755130Ab2FCXNf (ORCPT ); Sun, 3 Jun 2012 19:13:35 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:44162 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755074Ab2FCXNe (ORCPT ); Sun, 3 Jun 2012 19:13:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <20120601023107.GA19445@redhat.com> <20120601161205.GA1918@redhat.com> <20120601171606.GA3794@redhat.com> <20120603181548.GA306@redhat.com> <20120603183139.GA1061@redhat.com> <20120603205332.GA5412@redhat.com> From: Linus Torvalds Date: Sun, 3 Jun 2012 16:13:13 -0700 X-Google-Sender-Auth: dVP7z6mlpZKrjxfKJ2IKV_DjlVw Message-ID: Subject: Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170() To: Hugh Dickins Cc: Dave Jones , Bartlomiej Zolnierkiewicz , Kyungmin Park , Marek Szyprowski , Mel Gorman , Minchan Kim , Rik van Riel , Andrew Morton , Cong Wang , Markus Trippelsdorf , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 23 On Sun, Jun 3, 2012 at 3:17 PM, Hugh Dickins wrote: > > But another strike against that commit: I tried fixing it up to use > start_page instead of page at the end, with the worrying but safer > locking I suggested at first, with a count of how many times it went > there, and how many times it succeeded. You can't use start_page anyway, it might not be a valid page. There's a reson it does that "pfn_valid_within()", methinks. Anyway, my current plan is to apply your "mm: fix warning in __set_page_dirty_nobuffers" patch - even if it's just a harmless WARN_ON_ONCE(), and revert 5ceb9ce6fe94. Sounds like Dave hit normally hit his problem much before two hours, and it must be even longer now. Ack on that plan? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/