Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756769Ab2FDJ5E (ORCPT ); Mon, 4 Jun 2012 05:57:04 -0400 Received: from eu1sys200aog114.obsmtp.com ([207.126.144.137]:36900 "EHLO eu1sys200aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602Ab2FDJ5C convert rfc822-to-8bit (ORCPT ); Mon, 4 Jun 2012 05:57:02 -0400 From: Sjur BRENDELAND To: Ohad Ben-Cohen Cc: Loic PALLARDY , Ludovic BARRE , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus Walleij , =?iso-8859-1?Q?Sjur_Br=E6ndeland?= Date: Mon, 4 Jun 2012 11:56:47 +0200 Subject: RE: [RFC 3/6] remoteproc: Move fw sanity check to find_rsc_table. Thread-Topic: [RFC 3/6] remoteproc: Move fw sanity check to find_rsc_table. Thread-Index: Ac1BjrqFlXL0CpWUT/qRY8MgZ1E11QApAXwQ Message-ID: <81C3A93C17462B4BBD7E272753C10579232F4FBCF7@EXDCVYMBSTM005.EQ1STM.local> References: <1337693217-15466-1-git-send-email-sjur.brandeland@stericsson.com> <1337693217-15466-4-git-send-email-sjur.brandeland@stericsson.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 20 >> Prepare for pluggable firmware handling by calling firmware >> sanity check from function find_rsc_table. > > Can we keep the present location of rproc_fw_sanity_check(), and later > just invoke the relevant ops handler instead? The sanity_check() is working on the ELF structures. And all ELF processing needs to be moved to a separate file. So if you want to keep the call to sanity_check() here, I need to make the sanity_check() function a separate handler. That could make sense, but will also bloat the struct rproc_fw_ops with one more function pointer. Regards, Sjur -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/